chore: integrate security audit into threat model and issues#433
Merged
chore: integrate security audit into threat model and issues#433
Conversation
Full manual code review covering parser, interpreter, VFS, builtins, network layer, git support, Python bindings, and tool orchestration. Identified 27 findings (2 critical, 8 high, 10 medium, 7 low) including arithmetic panic/DoS, VFS limit bypass, internal variable namespace injection, process env pollution in jq, and shell injection in Python deepagents wrapper. https://claude.ai/code/session_011wB794wXwA9BMoj1sFKtrE
Add 15 new threat IDs discovered during comprehensive security audit: - TM-DOS-029 to TM-DOS-033: arithmetic panic, parser bypass, extglob DoS - TM-ESC-012, TM-ESC-013: VFS limit bypass via public API - TM-INF-013 to TM-INF-015: jq env leak, PID leak, URL credential leak - TM-INJ-009, TM-INJ-010: variable namespace injection, tar traversal - TM-ISO-004: cross-tenant env pollution - TM-GIT-014: branch name path injection - TM-PY-023 to TM-PY-025: shell injection, heredoc escape, GIL deadlock Update vulnerability summary, security controls matrix, and public docs. https://claude.ai/code/session_011wB794wXwA9BMoj1sFKtrE
Ensure every finding in SECURITY_AUDIT.md has a corresponding threat model entry. Added: - TM-DOS-034 to TM-DOS-040: TOCTOU, OverlayFs gaps, validate_path, 32-bit - TM-ESC-014: custom builtins lost after first call - TM-INJ-011: cyclic nameref silent resolution - TM-INF-016: error message info leaks - TM-PY-026: reset() discards config - TM-PY-027: JSON conversion unbounded recursion Updated vulnerability summary and open controls matrix in both specs/006-threat-model.md and public docs/threat-model.md. https://claude.ai/code/session_011wB794wXwA9BMoj1sFKtrE
All 27 findings are now tracked in GitHub issues (#405-#431) with severity labels, and all threat model IDs are in specs/006-threat-model.md. The file is no longer needed. https://claude.ai/code/session_011wB794wXwA9BMoj1sFKtrE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specs/006-threat-model.mdandcrates/bashkit/docs/threat-model.mdSECURITY_AUDIT.md— all content now lives in issues + threat modelDetails
12 findings were missing threat model entries (had issues but no TM-IDs). Added:
TM-DOS-034 through TM-DOS-040, TM-ESC-014, TM-INJ-011, TM-INF-016, TM-PY-026, TM-PY-027.
Updated vulnerability summary and open controls matrix in both spec and public docs.
Test plan
just checkpasses (no code changes, only markdown)gh issue list -l security -L 30